Quoting: liamdaweI have also adjusted them as requested to link directly to the comment, I should have done that to begin with so it was valid you bringing it up. Thanks.

Great job, man, and a very convenient feature.

*insert rum here as thanks* ;)

The rum goes in my tum, yum.

Oh, before you pop that cork, the Latest Forum Posts widget needs fixing as well.

I think having these kind of options acts as a good incentive to register even if you don't want to comment. That, and new survey. Customising in how I read and view site is a big plus for me. Not sure how others feel, but having this options surely enhances my experience.

Quoting: tuubiOh, before you pop that cork, the Latest Forum Posts widget needs fixing as well.

Should also now be fixed :)

Quoting: redshiftI think having these kind of options acts as a good incentive to register even if you don't want to comment. That, and new survey. Customising in how I read and view site is a big plus for me. Not sure how others feel, but having this options surely enhances my experience.

Glad I could help make it better :)

Any other issues, let me know.

I know that comment/post linking won't work correctly now, since everyone may see it on a different page. Currently brainstorming a solution, but it's not a major issue right now to spend too much time trying to fix just yet.

Quoting: liamdaweI know that comment/post linking won't work correctly now, since everyone may see it on a different page. Currently brainstorming a solution, but it's not a major issue right now to spend too much time trying to fix just yet.

I agree it's not a big problem and there's no hurry, but I at least tried to hint at a possible solution to this as well in my first comment. Drop the page number reference in the link urls and let the script that shows the article or forum post take care of showing the correct page of comments. This would also reduce the number of places that deal with paging and might make things simpler / more robust. Of course I've never seen your code and this might not be simple at all.

Just noticed that comment links in emails sent by the system can't deal with this stuff yet. One sent me to page 4/2 just now.

Quoting: tuubiJust noticed that comment links in emails sent by the system can't deal with this stuff yet. One sent me to page 4/2 just now.

For what exactly, forum post, article comment?
Fixed that, thanks.

Quoting: tuubi

Quoting: liamdaweI know that comment/post linking won't work correctly now, since everyone may see it on a different page. Currently brainstorming a solution, but it's not a major issue right now to spend too much time trying to fix just yet.

I agree it's not a big problem and there's no hurry, but I at least tried to hint at a possible solution to this as well in my first comment. Drop the page number reference in the link urls and let the script that shows the article or forum post take care of showing the correct page of comments. This would also reduce the number of places that deal with paging and might make things simpler / more robust. Of course I've never seen your code and this might not be simple at all.

It won't make anything simpler, as the current code would simply grab the page from the url (the simplest way). I will now need to do a bunch of math and check the post amounts in the database to work out a correct page.

Actually it will make two places a tiny bit simpler, since I won't work out pages for the email links. The rest is annoying though, actually working out the correct page when you hit the link with the comment_id. Will still need a wee think on it.

Quoting: liamdawe

Quoting: tuubiJust noticed that comment links in emails sent by the system can't deal with this stuff yet. One sent me to page 4/2 just now.

For what exactly, forum post, article comment?
Fixed that, thanks.

Don't thank me, you're the one that's working on a sunday. :P

Quoting: liamdaweIt won't make anything simpler, as the current code would simply grab the page from the url (the simplest way). I will now need to do a bunch of math and check the post amounts in the database to work out a correct page.

Actually it will make two places a tiny bit simpler, since I won't work out pages for the email links. The rest is annoying though, actually working out the correct page when you hit the link with the comment_id. Will still need a wee think on it.

Yeah, I didn't mean simpler in that sense. Just that it's often better to do the work in as few places as possible, even if it takes a bit more logic, thus reducing duplication of code and making the codebase simpler to manage.

Is it hard for the script to find out the position of the comment in the thread, and then just do a modulus with the user's comments-per-page setting to find out the page? (Hope that makes sense, I think my brain's on strike today.)