⨯ Don't want to see articles from a certain category? When logged in, go to your User Settings and adjust your feed in the Content Preferences section where you can block tags!
New theming live now - report issues here
Page: 1/3»
  Go to:
Liam Dawe Mar 29, 2020
Hi all, a big overhaul of the theme code went live today along with a theme-switcher you can find in the user/guest menu.

Note
Yes, the switcher requires JavaScript. Since I know some don't like that, you can still use the theme switcher in your User settings. That was also updated, as it now properly forces your picked theme there (which overrides the top nav slider).

Of course, there will be issues, some edge-cases I've missed.

If you see anything that doesn't look right or act right please let me know here so I can fix them. Before reporting, please refresh your cache to ensure it's not your browser keeping old CSS/JS around.

The forum
The old category/forum view is gone, long live flat forum. Honestly, it's just better, it matches the home page style of all categories shown. This way, categories that don't usually get a look-in will now actually have their posts show up when people make them.

Last edited by Liam Dawe on 29 March 2020 at 8:52 pm UTC
GustyGhost Mar 29, 2020
It is a nice improvement. I've always felt that forums do themselves a disservice by breaking everything up into many fine grained categories.
serge Mar 29, 2020
Hello,

If you switch to the dark theme and then close the browser, or go to another website and come back, you end up with the light theme.

If you Force the theme through the profile settings, it works fine.

Last edited by serge on 29 March 2020 at 4:14 pm UTC
Liam Dawe Mar 29, 2020
Quoting: sergeHello,

If you switch to the dark theme and then close the browser, or go to another website and come back, you end up with the light theme.

If you Force the theme through the profile settings, it works fine.
Not seeing that behaviour across firefox/chrome on both desktop and mobile. Sounds like you have something interfering with it. It's using local storage as the checker, perhaps you're wiping it or blocking it.
Donkey Mar 29, 2020
Quoting: Liam Dawe
Quoting: sergeHello,

If you switch to the dark theme and then close the browser, or go to another website and come back, you end up with the light theme.

If you Force the theme through the profile settings, it works fine.
Not seeing that behaviour across firefox/chrome on both desktop and mobile. Sounds like you have something interfering with it. It's using local storage as the checker, perhaps you're wiping it or blocking it.

I am seeing the same behaviour as well. Also when the dark theme is enabled and (re)loading the page, the toggle button "switches" after the page have finished loading which draws attention to it. I find it a bit annoying. At least now that I noticed it :)
Liam Dawe Mar 29, 2020
Okay, I believe I have solved the issue of the theme flashing between light for a split second and then dark if you've got it turned on using the slider. The issue is how JavaScript loads. The really small bit of code to detect the set theme, then use it is now bundled into the HTML so it's done before the page actually loads the body content - so no flashing :) (I also tested that on my crappy 4G connection on my phone, works great - no flashing at all and page loads quickly).

As it turns out, the above is exactly what Twitch do. Only realised after I did it, so it seems like the real solution that I fell into there :D

Haven't yet come up with a good solution for the switcher flicking between though. Happy to take on ideas.

I've moved the slider into the user menu on desktop/mobile menu. I'll also adjust for Guests/Not Logged In people to have a menu to do so too. Guests now have their own little menu.

Last edited by Liam Dawe on 29 March 2020 at 8:48 pm UTC
chris.echoz Apr 1, 2020
The dark theme isn't applied at all whenever I reload the page on Firefox 75.0b2.
The "theme" key in local storage is saved, though and set to "dark".

Since the attribute "data-theme" is set, your code doesn't even look at what's set in the local storage and just uses "default" as the value, as that's set in: <html data-theme="default" class=" idcae idcac" lang="en">

var website_theme='light';
if (document.documentElement.hasAttribute("data-theme")) {
    website_theme=document.documentElement.getAttribute("data-theme");
} else {

    // If I run this on its own, the theme changes to dark as expected.

    if (localStorage.getItem("theme")) { 
        if(localStorage.getItem("theme")=="dark") {
            website_theme="dark";
        }
    }
    else if (window.matchMedia("(prefers-color-scheme: dark)").matches) {
        website_theme="dark"
    }
    if (website_theme=="dark") {
        document.documentElement.setAttribute("data-theme","dark")
    }
}

Last edited by chris.echoz on 1 April 2020 at 9:58 pm UTC
Liam Dawe Apr 1, 2020
Quoting: chris.echozThe dark theme isn't applied at all whenever I reload the page on Firefox 75.0b2.
The "theme" key in local storage is saved, though and set to "dark".

Since the attribute "data-theme" is set, your code doesn't even look at what's set in the local storage and just uses "default" as the value, as that's set in: <html data-theme="dark" class=" idcae idcac" lang="en">

var website_theme='light';
if (document.documentElement.hasAttribute("data-theme")) {
    website_theme=document.documentElement.getAttribute("data-theme");
} else {

    // If I run this on its own, the theme changes to dark as expected.

    if (localStorage.getItem("theme")) { 
        if(localStorage.getItem("theme")=="dark") {
            website_theme="dark";
        }
    }
    else if (window.matchMedia("(prefers-color-scheme: dark)").matches) {
        website_theme="dark"
    }
    if (website_theme=="dark") {
        document.documentElement.setAttribute("data-theme","dark")
    }
}
Check your user preferences aren't set to the light theme, user settings in the UserCP on the site overrides that switch. Otherwise, it will be a cache issue your end or a plugin getting in the way as this works across chrome/firefox both desktop and mobile.

Edit: Actually just noticed it says default, that looks like a leftover issue from the switch. Hold on 5 mins.

Edit 2: Should be fixed, a bunch of people didn't have their theme correctly unset from "default" (which no longer exists) it's either nothing and set by the JS and the new toggle or forced as light/dark in the User Control Panel.

Last edited by Liam Dawe on 1 April 2020 at 10:06 pm UTC
chris.echoz Apr 1, 2020
Quoting: Liam Dawe
Quoting: chris.echozThe dark theme isn't applied at all whenever I reload the page on Firefox 75.0b2.
The "theme" key in local storage is saved, though and set to "dark".

Since the attribute "data-theme" is set, your code doesn't even look at what's set in the local storage and just uses "default" as the value, as that's set in: <html data-theme="dark" class=" idcae idcac" lang="en">

var website_theme='light';
if (document.documentElement.hasAttribute("data-theme")) {
    website_theme=document.documentElement.getAttribute("data-theme");
} else {

    // If I run this on its own, the theme changes to dark as expected.

    if (localStorage.getItem("theme")) { 
        if(localStorage.getItem("theme")=="dark") {
            website_theme="dark";
        }
    }
    else if (window.matchMedia("(prefers-color-scheme: dark)").matches) {
        website_theme="dark"
    }
    if (website_theme=="dark") {
        document.documentElement.setAttribute("data-theme","dark")
    }
}
Check your user preferences aren't set to the light theme, user settings in the UserCP on the site overrides that switch. Otherwise, it will be a cache issue your end or a plugin getting in the way as this works across chrome/firefox both desktop and mobile.

Edit: Actually just noticed it says default, that looks like a leftover issue from the switch. Hold on 5 mins.
That did it, even without forcing the theme in the user CP it now stays dark if I set it to dark with the switch.
Liam Dawe Apr 1, 2020
Quoting: chris.echozThat did it, even without forcing the theme in the user CP it now stays dark if I set it to dark with the switch.
See my above reply, no need to force it in UserCP unless you want to. Should be all good now.
chris.echoz Apr 1, 2020
Quoting: Liam Dawe
Quoting: chris.echozThat did it, even without forcing the theme in the user CP it now stays dark if I set it to dark with the switch.
See my above reply, no need to force it in UserCP unless you want to. Should be all good now.
Can confirm it works as intended now.
While you're here, please consider supporting GamingOnLinux on:

Reward Tiers: Patreon. Plain Donations: PayPal.

This ensures all of our main content remains totally free for everyone! Patreon supporters can also remove all adverts and sponsors! Supporting us helps bring good, fresh content. Without your continued support, we simply could not continue!

You can find even more ways to support us on this dedicated page any time. If you already are, thank you!
Login / Register

Or login with...
Sign in with Steam Sign in with Google
Social logins require cookies to stay logged in.
Register Forgot Login?
★ Support Us
Popular this week
Search or view by category
Contact
Buy Games
Buy games with our affiliate / partner links:
Latest Comments
Latest Forum Posts
Misc