Er, I meant 17.4.

Hm. That should include Mesa shader caching already. Not much can be done about it then it seems. I think Wine developers were working on Wine's own shader caching, but it never hit upstream. Not sure what happened to that effort.

https://dev.wine-staging.com/patches/submission/247/

No luck last night. For whatever reason I can't get the new patch to apply. I cloned wine staging and then acquired the latest patch you referenced and even performed the git reset etc. that you pointed out earlier in this thread.

I'll continue tonight since I have more time.

No luck last night. For whatever reason I can't get the new patch to apply.

You are right, current staging patch is broken, and the updated version for it posted above works neither for Wine master. Let me see if it can be fixed.

I posted a fixed patch here: https://bugs.winehq.org/show_bug.cgi?id=42592#c56

I posted a fixed patch here

Thank you! I'll try when I get home from work. As someone interested in eventually contributing back to WINE, is there any place you'd recommend I start?

Thank you! I'll try when I get home from work. As someone interested in eventually contributing back to WINE, is there any place you'd recommend I start?

Just start building it from source. Check out bugs that affect games that you are interested in (and report ones that aren't reported yet).

For building Wine geared for TW3, I made a script here: https://gist.github.com/shmerl/bbd448bc2b579831a82df7bae3de8dc5

There was another fix needed for the patch. See the final version here: https://bugs.winehq.org/attachment.cgi?id=60429

Thank you for that. Got a bit busy it seems but I was finally able to get around to trying this. I successfully applied the patch you made, enabled CSMT, mesa-threading, and ran the game. It does indeed fix the cave entrances issue however I noticed that the audio was slightly popping. It's nowhere near as bad as when I attempted to run TW3 using stock 3.1 wine, but it is there and I don't recall experiencing it on 2.21-staging. I can only really hear it if a scene is quiet or I'm using my witcher senses.

I then set out to apply the second patch referenced (Shader parameter caching) and rebuild wine. The build process failed with the second patch applied. I'm going to rebuild wine with only your patch for now.

I didn't test the shader caching patch, so can't comment on it. I suppose it's also behind Wine master.

Regarding audio - I'm not sure. I thought it was fixed with some Wine commits that obsoleted similar staging patches (see here. Also, try restarting pulseaudio for a test?

If you still hear it, please open a new bug.

And if nothing else works, try doing this (for your Witcher wine prefix):

winetricks xact_jun2010

To run winetricks against your prefix and Wine version you need to set some variables as well, but you probably know about that.

Hi,

If using PulseAudio reducing the audio latency solves to popping/crackling sound for me:

export PULSE_LATENCY_MSEC=10 (or similar)

Might need to start wine/steam from that shell and/or restart pulse.

/Anders

If using PulseAudio reducing the audio latency solves to popping/crackling sound for me:

export PULSE_LATENCY_MSEC=10 (or similar)

Might need to start wine/steam from that shell and/or restart pulse.

Yeah, but I'm a bit surprised it's a problem on such a good CPU as Threadripper.

I'm pretty sure the above is just a bug in PulseAudio that shows up in Witcher?
The crackling/popping happens even in loading, menu (before game) and paused (or similar) when there is zero load on both the CPU and the GPU.
Might be related to AMD CPUs still, but not due to "performance".

EDIT: I've lost count in all the bugs in PulseAudio - been better last year or so but still feels like something a kid programmer whipped together during a summer of code first time coding. :D

Today wine master fps 1-2 winetricks glsl=enabled csmt=on
View video on youtube.com
, wine +wined3d-buffer_create 14-20 fps
View video on youtube.com
@Shmerl any idea? https://dev.wine-staging.com/patches/submission/269/

I'll test it later today.

If I get some time this weekend I'll test as well. Though my results will be different due to me using mesa with AMD.

Just did a clean build based on 389c3ad comctl32/button: Fix paint handler check when theming is on.

With
../wine/configure --enable-win64 --prefix=/opt/wine-build CFLAGS="-O4" CC="gcc-7"
and
PKG_CONFIG_PATH=/usr/lib32 ../wine/configure --with-wine64=../wine-build --prefix=/opt/wine-build CC="gcc-7"

Won't launch, just a black screen, hangs, and the following error message:
00c4:err:seh:setup_exception stack overflow 1712 bytes in thread 00c4 eip 000000007bc65c29 esp 000000003b020f60 stack 0x3b020000-0x3b021000-0x3b220000


Any ideas? Haven't built manually since 3.0 was released.
Won't have time to bisect. :-/

I built normal Wine 3.1 last weekend without any patches, it provided same results as malek. GTX 1060 / 384.111 - 3fps max

I built normal Wine 3.1 last weekend without any patches, it provided same results as malek. GTX 1060 / 384.111 - 3fps max

That's expected without the buffers patch, but probably before it wasn't that bad. There is now some work going on with this in Wine master, so buffers patch is now somewhat incorrect.

https://bugs.winehq.org/show_bug.cgi?id=42592

Well, the wined3d_pool enum no longer exists in current Wine git, so any hack based on that will run into issues. If you want to do a hack, I'd suggest starting with not setting WINED3D_RESOURCE_ACCESS_CPU in d3d11's d3d_buffer_init(), unless "Usage" is D3D11_USAGE_STAGING, in which case you don't want WINED3D_RESOURCE_ACCESS_GPU. This is also an area that's currently seeing active development though; any hack is likely to get broken again relatively soon.

— Henri Verbeet